Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IO dispatcher for cleanup in bug reporter #3092

Merged

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Run the cleanup after sending a bug report in the IO dispatcher.

Motivation and context

Fixes #3086 (I hope).

Tests

I couldn't reproduce this even with strict mode enabled, but the instruction should be:

  • In the OS developer options enable strict mode.
  • Send a test bug report.
  • If it doesn't crash after sending, it's fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 25, 2024 06:51
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 25, 2024 06:51
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/o4jAYY

Copy link

sonarcloud bot commented Jun 25, 2024

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (ec06ce4) to head (d469cb6).
Report is 7 commits behind head on develop.

Files Patch % Lines
...ures/rageshake/impl/reporter/DefaultBugReporter.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3092   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1634     1634           
  Lines        38596    38597    +1     
  Branches      7461     7461           
========================================
+ Hits         29326    29328    +2     
  Misses        5380     5380           
+ Partials      3890     3889    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 25, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) June 25, 2024 09:12
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 25, 2024
@jmartinesp jmartinesp merged commit 40b7736 into develop Jun 25, 2024
27 of 28 checks passed
@jmartinesp jmartinesp deleted the fix/jme/3086-network-on-main-thread-in-bug-reporting branch June 25, 2024 09:26
@ganfra ganfra added the PR-Bugfix For bug fix label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash while reporting logs
2 participants