Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the 'answer' PendingIntent in ringing call notifications #3093

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Added the CANCEL_CURRENT flag to the pending intent so it's replaced.

Motivation and context

Fixes #3085.

Tests

  • Receive a ringing call from another user. Ignore or decline it.
  • Receive a new one from a different user, answer it.

The call you join should be the 2nd one, not the first one.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 25, 2024 07:17
@jmartinesp jmartinesp requested review from bmarty and removed request for a team June 25, 2024 07:17
Copy link
Contributor

github-actions bot commented Jun 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FcCEKF

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.98%. Comparing base (ec06ce4) to head (abf1152).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3093   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1634     1634           
  Lines        38596    38596           
  Branches      7461     7461           
========================================
  Hits         29326    29326           
  Misses        5380     5380           
  Partials      3890     3890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just a question about the impact for the user.

changelog.d/3085.bugfix Outdated Show resolved Hide resolved
Co-authored-by: Benoit Marty <benoit@matrix.org>
Copy link

sonarcloud bot commented Jun 25, 2024

@jmartinesp jmartinesp merged commit ce28a05 into develop Jun 25, 2024
23 checks passed
@jmartinesp jmartinesp deleted the fix/jme/update-ringing-call-pending-intents branch June 25, 2024 08:36
@toger5
Copy link

toger5 commented Jun 25, 2024

Super nice to have this fixes so quickly.

@ganfra ganfra added the PR-Bugfix For bug fix label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken pending intent when accepting a incoming call via the OS notification banner.
4 participants