-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Draft support #3099
Feature : Draft support #3099
Conversation
…on't mess up with draft restoration.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3099 +/- ##
===========================================
- Coverage 75.97% 75.96% -0.01%
===========================================
Files 1634 1636 +2
Lines 38611 38629 +18
Branches 7463 7467 +4
===========================================
+ Hits 29335 29345 +10
- Misses 5384 5395 +11
+ Partials 3892 3889 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...oser/impl/src/main/kotlin/io/element/android/libraries/textcomposer/model/TextEditorState.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a long composer! I guess the state is expanded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like #2167
Type of change
Content
Implement draft support in the following way :
This PR also introduce some refactoring around ReplyTo, so we can use the same UI logic between Timeline item and Composer.
Motivation and context
Closes #2869
Screenshots / GIFs
Tests
Tested devices
Checklist