Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFs can now be toggled in release builds too #3101

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jun 26, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Removed StaticFeatureFlagProvider.
  • Always provide PreferencesFeatureFlagProvider.
  • For the default values of feature flags, use a lambda with a BuildMeta parameter so we can customize the return value based on its data.

Motivation and context

Fixes #3073.

Tests

  • In a release build, access the hidden developer settings.
  • Toggle one of the many options.
  • Check the change took effect.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

Copy link
Contributor

github-actions bot commented Jun 26, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pjoFpK

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (0c543ab) to head (a4872dc).
Report is 84 commits behind head on develop.

Current head a4872dc differs from pull request most recent head d7a2340

Please upload reports for the commit d7a2340 to get more accurate results.

Files Patch % Lines
...featureflag/impl/PreferencesFeatureFlagProvider.kt 0.00% 2 Missing ⚠️
...libraries/featureflag/impl/di/FeatureFlagModule.kt 0.00% 2 Missing ⚠️
.../android/libraries/featureflag/api/FeatureFlags.kt 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3101      +/-   ##
===========================================
+ Coverage    75.96%   76.00%   +0.03%     
===========================================
  Files         1636     1635       -1     
  Lines        38617    38600      -17     
  Branches      7463     7461       -2     
===========================================
+ Hits         29335    29337       +2     
+ Misses        5393     5373      -20     
- Partials      3889     3890       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Removed `StaticFeatureFlagProvider`.
- Always provide `PreferencesFeatureFlagProvider`.
- For the default values of feature flags, use a lambda with a `BuildMeta` parameter so we can customize the return value based on its data.
@jmartinesp jmartinesp force-pushed the fix/jme/3073-feature-flags-cannot-be-toggled-in-release-builds branch from 9d50729 to a4872dc Compare June 28, 2024 09:52
@jmartinesp jmartinesp marked this pull request as ready for review June 28, 2024 09:53
@jmartinesp jmartinesp requested a review from a team as a code owner June 28, 2024 09:53
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 28, 2024 09:53
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Jun 28, 2024
@jmartinesp jmartinesp changed the title FFs can now be toggle in release builds too FFs can now be toggled in release builds too Jul 2, 2024
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) July 2, 2024 15:18
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

@jmartinesp jmartinesp merged commit 32a374d into develop Jul 2, 2024
28 checks passed
@jmartinesp jmartinesp deleted the fix/jme/3073-feature-flags-cannot-be-toggled-in-release-builds branch July 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature flags cannot be toggled on release builds
2 participants