Auth : fix restore session when there is no network. #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
commented
Jun 27, 2024
| @@ -48,7 +47,7 @@ class RustMatrixClientFactory @Inject constructor( | |||
| ) { | |||
| suspend fun create(sessionData: SessionData): RustMatrixClient = withContext(coroutineDispatchers.io) { | |||
| val client = getBaseClientBuilder(sessionData.sessionPath, sessionData.passphrase) | |||
| .serverNameOrHomeserverUrl(sessionData.homeserverUrl) | |||
| .homeserverUrl(sessionData.homeserverUrl) | |||
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
jmartinesp
approved these changes
Jun 27, 2024
ganfra
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3109 +/- ##
========================================
Coverage 75.96% 75.96%
========================================
Files 1636 1636
Lines 38617 38617
Branches 7463 7463
========================================
Hits 29335 29335
Misses 5393 5393
Partials 3889 3889 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
When app is launched in airplane mode, the user is presented with login screen.
Using
ClientBuilder.serverNameOrhomeserverUrlis launching some network requests, which failed.Also made some changes so we don't configure slidingSyncProxy when restoring a session.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist