Fix incorrect 'device verified' screen when app was opened with no network connection #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the user opened the app with no network connection. It turns out `encryptionService.verificationState()` runs a network request that will cause a deadlock when it fails. Also fixed another deadlock that caused the screen to remain blank sometimes after logging in, because DataStore got stuck when checking the `skipVerification` state for some reason I don't fully understand.
jmartinesp
force-pushed
the
fix/jme/session-verification-state-with-no-network
branch
from
faaeff3
to
f421f94
Compare
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3110 +/- ##
========================================
Coverage 75.96% 75.96%
========================================
Files 1636 1636
Lines 38617 38618 +1
Branches 7463 7463
========================================
+ Hits 29335 29336 +1
Misses 5393 5393
Partials 3889 3889 ☔ View full report in Codecov by Sentry. |
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
bmarty
approved these changes
Jul 1, 2024
| Timber.d("Updating verification status: flow just finished") | ||
| runCatching { | ||
| encryptionService.waitForE2eeInitializationTasks() | ||
| }.onSuccess { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
skipVerificationpreference. I'd rather just remove it, but it's needed as a workaround onAppMigration02.Motivation and context
It turns out
encryptionService.verificationState()runs a network request that will cause a deadlock when it fails and that will trigger a timeout that will assume your session needs to be verified.Also fixed another deadlock that caused the screen to remain blank sometimes after logging in, because DataStore got stuck when checking the
skipVerificationstate for some reason I don't fully understand. We'll have to keep an eye on similar behaviours through the app.Tests
Tested devices
Checklist