Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline : re-enable edition of local echo #3126

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Re-enable edition of local echo.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review July 2, 2024 09:43
@ganfra ganfra requested a review from a team as a code owner July 2, 2024 09:43
@ganfra ganfra requested review from bmarty and removed request for a team July 2, 2024 09:43
@ganfra ganfra added PR-Feature For a new feature Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Jul 2, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

github-actions bot commented Jul 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rdbEFh

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (b46f47f) to head (82df03f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3126   +/-   ##
========================================
  Coverage    75.96%   75.96%           
========================================
  Files         1638     1638           
  Lines        38629    38629           
  Branches      7465     7465           
========================================
  Hits         29344    29344           
  Misses        5397     5397           
  Partials      3888     3888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra enabled auto-merge July 2, 2024 12:04
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@ganfra ganfra merged commit 1c8d1f7 into develop Jul 2, 2024
37 checks passed
@ganfra ganfra deleted the feature/fga/timeline_edit_local_echo branch July 2, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants