Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Element Enterprise nightly build and publication using App Distribution #3130

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure that the codebase correctly create EE nightly build.
Also made some change on the Firebase console to allow nightly to be published.

Motivation and context

Nightly build for Element Enterprise

Screenshots / GIFs

NA

Tests

  • In App Tester application, observe the Element Enterprise is available.

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jul 2, 2024
@bmarty bmarty requested a review from a team as a code owner July 2, 2024 14:53
@bmarty bmarty requested review from ganfra and removed request for a team July 2, 2024 14:53
Copy link
Contributor

github-actions bot commented Jul 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YEHSMR

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.95%. Comparing base (1c8d1f7) to head (0d8064b).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3130   +/-   ##
========================================
  Coverage    75.95%   75.95%           
========================================
  Files         1638     1638           
  Lines        38630    38630           
  Branches      7464     7464           
========================================
  Hits         29343    29343           
  Misses        5399     5399           
  Partials      3888     3888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@bmarty bmarty enabled auto-merge July 2, 2024 15:25
@bmarty bmarty merged commit 4757aac into develop Jul 2, 2024
28 of 29 checks passed
@bmarty bmarty deleted the feature/bma/fixElementEnterpriseNightly branch July 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants