Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : avoid potential NPE on verification service. #3140

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 4, 2024

StateFlow.value was potentially called by verification listener before it has been created, so move them at the top.

@ganfra ganfra marked this pull request as ready for review July 4, 2024 12:52
@ganfra ganfra requested a review from a team as a code owner July 4, 2024 12:52
@ganfra ganfra requested review from jmartinesp and removed request for a team July 4, 2024 12:52
Copy link
Contributor

github-actions bot commented Jul 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kMrTzS

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (646791e) to head (c8a01e3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3140   +/-   ##
========================================
  Coverage    76.02%   76.02%           
========================================
  Files         1635     1635           
  Lines        38605    38605           
  Branches      7467     7467           
========================================
  Hits         29349    29349           
  Misses        5366     5366           
  Partials      3890     3890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 4, 2024

@ganfra ganfra enabled auto-merge July 4, 2024 13:49
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 4, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 4, 2024
@ganfra ganfra merged commit d9d5a06 into develop Jul 4, 2024
31 checks passed
@ganfra ganfra deleted the feature/fga/fix_npe_on_verification_service branch July 4, 2024 14:05
@ganfra ganfra added the PR-Bugfix For bug fix label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants