Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon for "Mark as read" and "Mark as unread" actions. #3144

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add icon for "Mark as read" and "Mark as unread" actions. #3144

merged 2 commits into from
Jul 5, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 5, 2024

Icons are coming from Compound 0.0.7 which has just been released.

See recorded screenshots.

@bmarty bmarty requested a review from a team as a code owner July 5, 2024 08:16
@bmarty bmarty requested review from ganfra and removed request for a team July 5, 2024 08:16
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 5, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 5, 2024
@bmarty bmarty added the PR-Change For updates to an existing feature label Jul 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WwcbJs

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (c3ca3d9) to head (02224b5).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3144   +/-   ##
========================================
  Coverage    76.02%   76.03%           
========================================
  Files         1635     1635           
  Lines        38609    38608    -1     
  Branches      7467     7464    -3     
========================================
+ Hits         29353    29354    +1     
  Misses        5366     5366           
+ Partials      3890     3888    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ganfra
ganfra approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing.

@ganfra ganfra merged commit ddcb17f into develop Jul 5, 2024
33 checks passed
@ganfra ganfra deleted the feature/bma/markAsReadIcon branch July 5, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
PR-Change For updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @ganfra