Remove Showkase processor not found warning from Danger #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
misc/jme/remove-showkase-warning-from-danger
branch
2 times, most recently
from
dc2dc9e
to
482f166
Compare
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3148 +/- ##
========================================
Coverage 76.03% 76.03%
========================================
Files 1635 1635
Lines 38608 38608
Branches 7464 7464
========================================
Hits 29354 29354
Misses 5366 5366
Partials 3888 3888 ☔ View full report in Codecov by Sentry. |
jmartinesp
force-pushed
the
misc/jme/remove-showkase-warning-from-danger
branch
from
aaad970
to
373ca5a
Compare
🎉 |
Instead create a new rule to check if the package name is included in `ComposablePreviewProvider`.
jmartinesp
force-pushed
the
misc/jme/remove-showkase-warning-from-danger
branch
from
373ca5a
to
a6f9762
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Remove Danger check to ensure Showkase is enabled in modules with previews. Instead try to check if the package of the preview is in the list of packages to scan in
ComposablePreviewProvider.Motivation and context
We don't use Showkase anymore for this.
Tests
The CI failed before when the new rule was broken: #3148 (comment)
Checklist