Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --alignment-preserved true when signing APK for F-Droid. #3161

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 8, 2024

Content

Add parameter --alignment-preserved true when signing APK for F-Droid to ensure reproducible build is working as expected.

Second commit is improving the PR template, I am lazy to create a PR just for this.

Motivation and context

Closes #3151

Screenshots / GIFs

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner July 8, 2024 12:48
@bmarty bmarty requested review from jmartinesp and removed request for a team July 8, 2024 12:48
Copy link
Contributor

github-actions bot commented Jul 8, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NBEtNf

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (c550436) to head (33b8f65).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3161   +/-   ##
========================================
  Coverage    76.02%   76.02%           
========================================
  Files         1635     1635           
  Lines        38559    38559           
  Branches      7457     7457           
========================================
  Hits         29313    29313           
  Misses        5360     5360           
  Partials      3886     3886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/fdoirBuildFix branch from 33b8f65 to 03ce6cf Compare July 8, 2024 16:21
@bmarty bmarty merged commit 4640233 into develop Jul 8, 2024
8 checks passed
@bmarty bmarty deleted the feature/bma/fdoirBuildFix branch July 8, 2024 16:21
Copy link

sonarcloud bot commented Jul 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid can't verify
2 participants