Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pin grace period to 2 minutes #3172

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 10, 2024

Content

2efa7fe: Change the PIN grace period to 2 minutes. In particular it prevent the user from entering the PIN again when taking a photo or picking a file to share as attachment (if the operation last less than 2 minutes)

For the other changes, this is just cleanup of the codebase.

Motivation and context

More user friendly application.

Screenshots / GIFs

Tests

  • Configure PIN code
  • in a room try to share a îcture from the gallery
  • Previously: the PIN code was requested when coming back to the application
  • Now: if the operation does not take more than 2 minutes, no need to enter the PIN code.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner July 10, 2024 14:30
@bmarty bmarty requested review from ganfra and removed request for a team July 10, 2024 14:30
@bmarty bmarty added the PR-Change For updates to an existing feature label Jul 10, 2024
Copy link
Contributor

github-actions bot commented Jul 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5AxAGT

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.10%. Comparing base (573cd5e) to head (eb8d7e2).

Files Patch % Lines
...droid/features/lockscreen/impl/LockScreenConfig.kt 50.00% 8 Missing ⚠️
...res/lockscreen/impl/setup/pin/SetupPinPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3172      +/-   ##
===========================================
- Coverage    76.11%   76.10%   -0.01%     
===========================================
  Files         1641     1642       +1     
  Lines        38624    38639      +15     
  Branches      7471     7471              
===========================================
+ Hits         29397    29406       +9     
- Misses        5335     5342       +7     
+ Partials      3892     3891       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 10, 2024
@bmarty bmarty enabled auto-merge July 10, 2024 15:01
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 10, 2024
Copy link

sonarcloud bot commented Jul 10, 2024

@bmarty bmarty merged commit 1a03edb into develop Jul 10, 2024
28 checks passed
@bmarty bmarty deleted the feature/bma/pinGracePeriod branch July 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants