-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pip and add feature flag. #3199
Conversation
The Activity is actually not destroyed as I expected.
val isSupportedByTheOs = Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && | ||
context.packageManager?.hasSystemFeature(PackageManager.FEATURE_PICTURE_IN_PICTURE).orFalse() | ||
return if (isSupportedByTheOs) { | ||
runBlocking { featureFlagService.isFeatureEnabled(FeatureFlags.PictureInPicture) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK to use a runBlocking
here, since at some point the FF will be removed.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3199 +/- ##
==========================================
Coverage ? 76.11%
==========================================
Files ? 1643
Lines ? 38686
Branches ? 7480
==========================================
Hits ? 29446
Misses ? 5349
Partials ? 3891 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Content
Add feature flag for PiP, disabled in production for now.
Change Call screen top left icon, when pip is supported, use a Back arrow instead of a Close. Closes #3197
Hang up when the Pip is closed.
Motivation and context
Improve Pip feature, and disable the feature until it is correctly tested and production ready.
Screenshots / GIFs
Tests
Tested devices
Checklist