Fix pillification not working for non formatted message bodies

[jmartinesp]

Content

Pure Markdown bodies weren't being 'pillified' so their mentions were turned into UI elements in the timeline.

A new pillifiedBody property was added to TimelineItemTextBasedContent to fix this.

Motivation and context

#2966

Screenshots / GIFs

There shouldn't be any changes 🤞 .

Tests

• Send a message with a single @room mention.
• Check the message is properly rendered in the timeline with the @room pill.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/x8juJt

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (2ff5fa6) to head (04880ec).
Report is 25 commits behind head on develop.

Files	Patch %	Lines
.../timeline/components/event/TimelineItemTextView.kt	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3201   +/-   ##
========================================
  Coverage    76.15%   76.15%           
========================================
  Files         1645     1645           
  Lines        38738    38747    +9     
  Branches      7496     7496           
========================================
+ Hits         29501    29509    +8     
  Misses        5343     5343           
- Partials      3894     3895    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks, the pillification is working as expected. But there are still difference when sending @room from Element Web and from EXA (tested in a DM):

Also on EXA I do not have completion for @room, I have it on Web. This may be fixed later, not related to this PR.

EDIT: apparently this is working as expected: code

[bmarty]

Is all this block equivalent to this simpler form?

    val formattedBody = content.formattedBody ?: content.pillifiedBody
    val textWithMentions = remember(formattedBody, mentionSpanTheme, lastCacheUpdate) {
        updateMentionSpans(formattedBody, userProfileCache)
        mentionSpanTheme.updateMentionStyles(formattedBody)
        formattedBody
    }

[jmartinesp]

Yeah, nice catch!

[bmarty]

Kudos for adding some documentation 👍

[bmarty]

I prefer to have a default lambda content with lambdaError() so that we ensure that it's not called when it's not expected, which is actually doing more test. Note that in this particular case, this is maybe OK to keep the current default implementation. I let you choose what's best.

[jmartinesp]

This component is sometimes used as a dependency deep in the hierarchy so I think it's better to not have to customise it for testing other components that may depend on it for functionality but don't check its output.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud