-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the risk of text truncation in buttons. #3209
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
...nsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/Button.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3209 +/- ##
========================================
Coverage 76.14% 76.15%
========================================
Files 1644 1644
Lines 38768 38776 +8
Branches 7501 7503 +2
========================================
+ Hits 29521 29529 +8
Misses 5350 5350
Partials 3897 3897 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Content
Introduce
ButtonSize.MediumLowPadding
andButtonSize.LargeLowPadding
to reduce the risk of text truncation. Translation can be quite longer that English words.Motivation and context
Less truncated text in buttons. Fix issue in German for accept/decline invitation in room list and in the room preview screen for invitation.
Screenshots / GIFs
See recorded one.
Tests
Can also be tested by replacing in the code
@PreviewsDayNight
by@Preview(locale = "de", widthDp = 360)
forJoinRoomViewPreview
and forRoomListViewPreview
Tested devices
Checklist