-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that the manual dark theme is rendering correctly regarding -night resource and keyboard #3216
Conversation
…ght resource and keyboard.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Theme.Dark -> AppCompatDelegate.MODE_NIGHT_YES | ||
} | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it could be done elsewhere, for instance in RootPresenter
, but when the value is the same, setDefaultNightMode
has no effect, so I guess it's fine to do it here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3216 +/- ##
===========================================
- Coverage 76.14% 76.13% -0.01%
===========================================
Files 1645 1645
Lines 38809 38815 +6
Branches 7516 7517 +1
===========================================
+ Hits 29552 29553 +1
- Misses 5356 5362 +6
+ Partials 3901 3900 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Content
Ensure that the system is aware about "forced" dark theme.
Using
AppCompatDelegate.setDefaultNightMode
is actually working like a charm, I have not found any regression.Motivation and context
Full dark theme when system setting is set to light and application setting is set to dark.
Closes #3168
Screenshots / GIFs
Tests
-nightly
folder are not used when theme is forced to "Dark" #3168)Try to change system theme and application theme and observe that the application is always rendering the expected theme.
Tested devices
Checklist