Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering issue of SunsetPage in dark mode #3217

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 18, 2024

Content

Remove the alpha channel of the 2 images: reduce the image size and fixes an issue in dark mode.

Motivation and context

Perfect color transition between the top background (dark color) and the sunset image, see the screenshots below.

Screenshots / GIFs

Before After
Screenshot 2024-07-18 at 15 48 25 image

Tests

  • Easiest way to test is to force the state in the migration mode, in roomListContentState Composable, set showMigration to true.

Strangely I cannot repro the issue using the Preview, for instance by adding a colored background.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Reduce the image size and fixes an issue in dark mode.
@bmarty bmarty added the PR-Bugfix For bug fix label Jul 18, 2024
@bmarty bmarty requested a review from a team as a code owner July 18, 2024 14:28
@bmarty bmarty requested review from jmartinesp and removed request for a team July 18, 2024 14:28
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ganfra will be very happy with this change!

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zSh9Bz

Copy link

sonarcloud bot commented Jul 18, 2024

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13%. Comparing base (4aa3961) to head (9308333).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3217   +/-   ##
========================================
  Coverage    76.13%   76.13%           
========================================
  Files         1645     1645           
  Lines        38816    38816           
  Branches      7517     7517           
========================================
  Hits         29554    29554           
  Misses        5362     5362           
  Partials      3900     3900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 95c3738 into develop Jul 18, 2024
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/moreUiFixes branch July 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants