Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified sliding sync toggle to developer options #3222

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

jmartinesp
Copy link
Member

Content

Add simplified sliding sync toggle to developer options. Make sure it's reset when logged out.

Motivation and context

This will let us test the new SSS implementation in EXA too.

Screenshots / GIFs

In the PR.

Tests

  • Log into an account in your own homeserver using the latest synapse sources.
  • Go to settings -> developer settings, enable simplified sliding sync.
  • Kill and restart the app.
  • The app will now use simplified sliding sync instead of the SS proxy.

Note you can also test this with matrix.org, but the deployed implementation fails to sync properly at the moment and ends up in a fail -> retry endless loop.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Feature For a new feature label Jul 19, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner July 19, 2024 13:20
@jmartinesp jmartinesp requested review from bmarty and removed request for a team July 19, 2024 13:20
Copy link
Contributor

github-actions bot commented Jul 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XCgav4

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.12%. Comparing base (947480f) to head (eec0e37).
Report is 5 commits behind head on develop.

Files Patch % Lines
...droid/features/logout/impl/DefaultLogoutUseCase.kt 0.00% 6 Missing ⚠️
...eferences/impl/store/DefaultAppPreferencesStore.kt 0.00% 4 Missing ⚠️
...ndroid/features/logout/impl/SessionLogoutModule.kt 0.00% 1 Missing ⚠️
...ences/impl/developer/DeveloperSettingsPresenter.kt 83.33% 0 Missing and 1 partial ⚠️
...references/impl/developer/DeveloperSettingsView.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3222      +/-   ##
===========================================
- Coverage    76.14%   76.12%   -0.02%     
===========================================
  Files         1645     1647       +2     
  Lines        38757    38780      +23     
  Branches      7527     7528       +1     
===========================================
+ Hits         29512    29522      +10     
- Misses        5335     5346      +11     
- Partials      3910     3912       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jmartinesp and others added 3 commits July 19, 2024 16:32
Instead, force a logout when toggling the option so user needs to log in again and create a new session using SSS.
@jmartinesp jmartinesp requested review from ganfra and removed request for bmarty July 22, 2024 08:40
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I just added a change on the ClientBuilder to avoid mistakes. Let me know what you think of it.

Copy link
Member Author

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over the PR @ganfra , your changes work and make sense to me.

@ganfra ganfra force-pushed the feature/jme/add-simplified-sliding-sync-toggle branch from d3ef45e to eec0e37 Compare July 25, 2024 08:09
@ganfra ganfra enabled auto-merge July 25, 2024 08:18
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 25, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 25, 2024
Copy link

sonarcloud bot commented Jul 25, 2024

@ganfra ganfra merged commit 2702737 into develop Jul 25, 2024
28 of 30 checks passed
@ganfra ganfra deleted the feature/jme/add-simplified-sliding-sync-toggle branch July 25, 2024 08:37
bmarty added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants