-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplified sliding sync toggle to developer options #3222
Add simplified sliding sync toggle to developer options #3222
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3222 +/- ##
===========================================
- Coverage 76.14% 76.12% -0.02%
===========================================
Files 1645 1647 +2
Lines 38757 38780 +23
Branches 7527 7528 +1
===========================================
+ Hits 29512 29522 +10
- Misses 5335 5346 +11
- Partials 3910 3912 +2 ☔ View full report in Codecov by Sentry. |
Instead, force a logout when toggling the option so user needs to log in again and create a new session using SSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I just added a change on the ClientBuilder to avoid mistakes. Let me know what you think of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over the PR @ganfra , your changes work and make sense to me.
d3ef45e
to
eec0e37
Compare
Quality Gate passedIssues Measures |
Content
Add simplified sliding sync toggle to developer options. Make sure it's reset when logged out.
Motivation and context
This will let us test the new SSS implementation in EXA too.
Screenshots / GIFs
In the PR.
Tests
Note you can also test this with
matrix.org
, but the deployed implementation fails to sync properly at the moment and ends up in a fail -> retry endless loop.Tested devices
Checklist