Rework FakeMatrixRoom so that it contains only lambdas. #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test compilation issues
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3229 +/- ##
========================================
Coverage 76.13% 76.14%
========================================
Files 1645 1645
Lines 38816 38728 -88
Branches 7520 7516 -4
========================================
- Hits 29554 29489 -65
+ Misses 5361 5336 -25
- Partials 3901 3903 +2 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Jul 22, 2024
| var sendCallNotificationIfNeededResult: () -> Result<Unit> = { Result.success(Unit) }, | ||
| canRedactOwn: Boolean = false, | ||
| canRedactOther: Boolean = false, | ||
| private var roomPermalinkResult: () -> Result<String> = { lambdaError() }, |
There was a problem hiding this comment.
I tend to make these public so we don't have to add extra given___ methods to modify them, but it's no big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually adding more tests, to ensure that only expected methods are used by unit tests.