Fix linkification not working for Spanned strings in text messages

[jmartinesp]

Content

Make CharSequence.withFixedURLSpans() handle any type of CharSequence, not only Spannable. If the text wasn't Spannable, a new one will be created from it.

Motivation and context

Previously, the RTE would always return a SpannableString as a result, and as the code checked for this is Spannable it worked fine.

Now a SpannedString is returned instead (the result of a buildSpannedString { ... } block), so the code was skipped.

This issue was found as a regression after upgrading the RTE version to 2.37.7 in #3218.

Tests

• Open a room where a plain link was sent inside a message with formatted_body.
• The link should be auto linkified again.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4iGEra

[ganfra]

Should we add some more tests ?

[jmartinesp]

Should we add some more tests ?

Yep, on it.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13%. Comparing base (3a9830f) to head (a1336e0).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3233   +/-   ##
========================================
  Coverage    76.13%   76.13%           
========================================
  Files         1645     1645           
  Lines        38839    38839           
  Branches      7530     7529    -1     
========================================
+ Hits         29570    29571    +1     
  Misses        5361     5361           
+ Partials      3908     3907    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.