-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit : fallback to room.edit when timeline item is not found. #3239
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
editMessage(eventId, transactionId, message.markdown, message.html, message.mentions) | ||
.onFailure { cause -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be mapFailure
instead, so the result of room.editMessage
is returned instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U're right, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we are not doing anything with the result, so I guess it doesn't really matter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3239 +/- ##
========================================
Coverage 76.14% 76.14%
========================================
Files 1645 1645
Lines 38751 38757 +6
Branches 7525 7527 +2
========================================
+ Hits 29506 29512 +6
+ Misses 5336 5335 -1
- Partials 3909 3910 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Content
Makes sure to use
room.edit
when event is not found in the timeline (mostly for draft).Motivation and context
Message is not edited if the event is not found in the timeline.
Screenshots / GIFs
Tests
Tested devices
Checklist