Feature/fga/push subscribe to room

[ganfra]

Content

Add a feature flag so we can try subscribing to room whenever we receive a notifiable push.

Motivation and context

To improve time to see timeline when opening the app from push notification.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WStWzm

[codecov]

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (b9942cc) to head (08030b5).
Report is 4 commits behind head on develop.

Files	Patch %	Lines
...raries/push/impl/push/OnNotifiableEventReceived.kt	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3257      +/-   ##
===========================================
- Coverage    76.13%   76.11%   -0.02%     
===========================================
  Files         1647     1647              
  Lines        38787    38801      +14     
  Branches      7530     7533       +3     
===========================================
+ Hits         29529    29534       +5     
- Misses        5347     5355       +8     
- Partials      3911     3912       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

I think that might be instantiating a timeline too?

[ganfra]

Yes the goal is also to create and cache a timeline before clicking the notification

[jmartinesp]

After enabling the developer option I see no /sync in the logs when receiving a notification. So maybe we need to start the sync service until we receive a first sync?

[ganfra]

After enabling the developer option I see no /sync in the logs when receiving a notification. So maybe we need to start the sync service until we receive a first sync?

I don't know if it's quick enough to wait for the app to be in foreground. Do you see improvements on your side?

[jmartinesp]

Actually my bad, I thought this PR was about opportunistic syncs when push notifications were received, so we could get updates for other subscribed rooms too, but it's only about optimising loading times for the timeline, right?

To be honest, I see no difference with or without the developer option in the debug build. Maybe it'll be more noticeable in the nightlies. I'll approve it so we can test it there.

[ganfra]

Ok, lets see and remove it if it's useless