Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Pinned events : start creating the banner ui, no logic. #3259

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 31, 2024

Content

Create the PinnedBanner UI with all the skeleton.

Motivation and context

Starts handling element-hq/element-x-ios#3059

Screenshots / GIFs

Check recored screenshots.

Tests

Nothing to test yet.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added PR-Wip For anything that isn't ready to ship and will be enabled at a later date Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Jul 31, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JBiB4m

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 82.38636% with 31 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (6b8dba6) to head (6ee86a2).

Files Patch % Lines
...ges/impl/pinned/banner/PinnedMessagesBannerView.kt 84.78% 4 Missing and 10 partials ⚠️
...roid/libraries/designsystem/utils/LazyListState.kt 33.33% 2 Missing and 6 partials ⚠️
...mpl/pinned/banner/PinnedMessagesBannerPresenter.kt 64.28% 2 Missing and 3 partials ⚠️
...ent/android/features/messages/impl/MessagesView.kt 91.66% 0 Missing and 2 partials ⚠️
...es/impl/pinned/banner/PinnedMessagesBannerState.kt 80.00% 0 Missing and 1 partial ⚠️
...id/features/messages/impl/timeline/TimelineView.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3259      +/-   ##
===========================================
+ Coverage    76.16%   76.18%   +0.02%     
===========================================
  Files         1648     1654       +6     
  Lines        38825    38985     +160     
  Branches      7532     7563      +31     
===========================================
+ Hits         29570    29701     +131     
- Misses        5353     5361       +8     
- Partials      3902     3923      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra marked this pull request as ready for review July 31, 2024 13:52
@ganfra ganfra requested a review from a team as a code owner July 31, 2024 13:52
@ganfra ganfra requested review from jmartinesp and removed request for a team July 31, 2024 13:52
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

* Returns whether the lazy list is currently scrolling up.
*/
@Composable
fun LazyListState.isScrollingUp(): Boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ganfra ganfra enabled auto-merge July 31, 2024 14:33
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 31, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 31, 2024
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 31, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 31, 2024
@ganfra ganfra merged commit 0bcfffd into develop Jul 31, 2024
29 checks passed
@ganfra ganfra deleted the feature/fga/pinned_message_banner_ui branch July 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Wip For anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants