-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Pinned events : start creating the banner ui, no logic. #3259
Conversation
…_message_banner_ui
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3259 +/- ##
===========================================
+ Coverage 76.16% 76.18% +0.02%
===========================================
Files 1648 1654 +6
Lines 38825 38985 +160
Branches 7532 7563 +31
===========================================
+ Hits 29570 29701 +131
- Misses 5353 5361 +8
- Partials 3902 3923 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Returns whether the lazy list is currently scrolling up. | ||
*/ | ||
@Composable | ||
fun LazyListState.isScrollingUp(): Boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Content
Create the PinnedBanner UI with all the skeleton.
Motivation and context
Starts handling element-hq/element-x-ios#3059
Screenshots / GIFs
Check recored screenshots.
Tests
Nothing to test yet.
Tested devices
Checklist