Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarcloud project key #3264

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

guillaumevillemont
Copy link
Contributor

Content

Motivation and context

For https://github.com/element-hq/sre-internal/issues/3184

Signed-off-by: Guillaume Villemont guillaumev@element.io

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@guillaumevillemont guillaumevillemont requested a review from a team as a code owner August 2, 2024 13:54
@guillaumevillemont guillaumevillemont requested review from jmartinesp and removed request for a team August 2, 2024 13:54
Copy link
Contributor

github-actions bot commented Aug 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZHHiuk

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (8a3489c) to head (e69de70).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3264   +/-   ##
========================================
  Coverage    76.20%   76.20%           
========================================
  Files         1656     1656           
  Lines        39008    39008           
  Branches      7567     7567           
========================================
  Hits         29727    29727           
  Misses        5355     5355           
  Partials      3926     3926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems to work, thanks!

@jmartinesp jmartinesp merged commit b7c498a into develop Aug 2, 2024
30 checks passed
@jmartinesp jmartinesp deleted the guillaumev/sonarcloud-rename branch August 2, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants