Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pinned message : render m.room.pinned events in timeline #3276

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Aug 6, 2024

Content

Allow rendering of m.room.pinned events in timeline

Motivation and context

Closes #3271

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra force-pushed the feature/fga/render_m.room.pinned_events branch from 1c3de5a to 5d2abd0 Compare August 6, 2024 15:29
@ganfra ganfra added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e8oLHr

Copy link

sonarcloud bot commented Aug 6, 2024

@ganfra ganfra marked this pull request as ready for review August 6, 2024 15:41
@ganfra ganfra requested a review from a team as a code owner August 6, 2024 15:41
@ganfra ganfra requested review from jmartinesp and removed request for a team August 6, 2024 15:41
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.18%. Comparing base (798313c) to head (f9d337e).
Report is 1 commits behind head on develop.

Files Patch % Lines
...aries/eventformatter/impl/StateContentFormatter.kt 14.28% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3276      +/-   ##
===========================================
- Coverage    76.20%   76.18%   -0.03%     
===========================================
  Files         1656     1656              
  Lines        39008    39021      +13     
  Branches      7567     7571       +4     
===========================================
+ Hits         29727    29729       +2     
- Misses        5355     5365      +10     
- Partials      3926     3927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 7, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 7, 2024
@jmartinesp
Copy link
Member

Should this still be using the PR-Wip label?

@ganfra
Copy link
Member Author

ganfra commented Aug 7, 2024

Should this still be using the PR-Wip label?

You're right, maybe not, it's kind of unrelated with the rest of the feature.

@ganfra ganfra added PR-Change For updates to an existing feature and removed PR-Wip For anything that isn't ready to ship and will be enabled at a later date labels Aug 7, 2024
@ganfra ganfra merged commit 839d419 into develop Aug 7, 2024
31 of 33 checks passed
@ganfra ganfra deleted the feature/fga/render_m.room.pinned_events branch August 7, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] State events for pinning and unpinning
2 participants