Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proguard config for nightly and release builds #3294

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

jmartinesp
Copy link
Member

Content

Add a proguard rules file for the pushprovider firebase module.

Motivation and context

For some reason it seems like this module needs extra proguard rules.

Tests

Nightlies are working again.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Aug 11, 2024
@jmartinesp jmartinesp requested a review from bmarty August 11, 2024 08:25
@jmartinesp jmartinesp requested a review from a team as a code owner August 11, 2024 08:25
Copy link
Contributor

github-actions bot commented Aug 11, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hV2syh

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (20d0278) to head (f9e3a67).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3294   +/-   ##
========================================
  Coverage    82.56%   82.56%           
========================================
  Files         1662     1662           
  Lines        38992    38992           
  Branches      4724     4724           
========================================
  Hits         32192    32192           
  Misses        5133     5133           
  Partials      1667     1667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 11, 2024

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.

@bmarty bmarty merged commit e376b5e into develop Aug 12, 2024
27 checks passed
@bmarty bmarty deleted the ci/jme/fix-nightly-reports-firebase branch August 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants