Ensure sessionPath is not reused for different homeserver. Fixes not loading media issue. #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3299 +/- ##
========================================
Coverage 82.56% 82.56%
========================================
Files 1662 1662
Lines 38992 38992
Branches 4724 4724
========================================
Hits 32193 32193
Misses 5133 5133
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Aug 12, 2024
| @@ -117,8 +126,9 @@ class RustMatrixAuthenticationService @Inject constructor( | |||
|
|
|||
| override suspend fun setHomeserver(homeserver: String): Result<Unit> = | |||
| withContext(coroutineDispatchers.io) { | |||
| val emptySessionPath = rotateSessionPath() | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Ensure the folder
sessionPathis not reused for different homeserver, else some cached data may be wrong.Rotate the folder and delete the previous one. One side effect is described in #3296 because API to get authentication media may or may not be available and this capability is stored in cache.
Motivation and context
Closes #3296
Screenshots / GIFs
NA
Tests
Before: media cannot be loaded
After: media can be loaded.
Tested devices
Checklist