Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and add unit test for DefaultPinnedMessagesBannerFormatter #3307

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 16, 2024

Cleanup and more unit tests.

@bmarty bmarty added the PR-Misc For other changes label Aug 16, 2024
@bmarty bmarty requested a review from a team as a code owner August 16, 2024 10:30
@bmarty bmarty requested review from jmartinesp and removed request for a team August 16, 2024 10:30
Copy link

sonarcloud bot commented Aug 16, 2024

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (b62348f) to head (f7d8e12).
Report is 26 commits behind head on develop.

Files Patch % Lines
...ges/impl/pinned/banner/PinnedMessagesBannerView.kt 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3307      +/-   ##
===========================================
+ Coverage    82.56%   82.66%   +0.10%     
===========================================
  Files         1675     1675              
  Lines        39204    39205       +1     
  Branches      4745     4745              
===========================================
+ Hits         32367    32408      +41     
+ Misses        5163     5123      -40     
  Partials      1674     1674              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wFqaoi

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 16, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 16, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 6b52859 into develop Aug 20, 2024
33 checks passed
@bmarty bmarty deleted the feature/bma/cleanup branch August 20, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants