Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test on MatrixRoom extension #3327

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add unit test on MatrixRoom extension #3327

merged 4 commits into from
Aug 22, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 22, 2024

Complement to #3324

@bmarty bmarty added the PR-Misc For other changes label Aug 22, 2024
@bmarty bmarty marked this pull request as ready for review August 22, 2024 13:26
@bmarty bmarty requested a review from a team as a code owner August 22, 2024 13:26
@bmarty bmarty requested review from jmartinesp and removed request for a team August 22, 2024 13:26
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/opty3o

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (a942fd4) to head (bb08525).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3327      +/-   ##
===========================================
+ Coverage    82.74%   82.76%   +0.01%     
===========================================
  Files         1680     1680              
  Lines        39380    39374       -6     
  Branches      4778     4776       -2     
===========================================
+ Hits         32585    32586       +1     
+ Misses        5117     5115       -2     
+ Partials      1678     1673       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit eeeb8fc into develop Aug 22, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/moreTests branch August 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants