Improve the text for mentions and replies in notifications #3328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
When we receive a notification with a message that either mentions or replies to the current user - since we can't know if it mentioned or replied to, it's either both or none - instead of setting its text to
Foo mentioned you: actual message
we'll create a fakePerson
to display in theMessagingStyle
for the notification, similar to what WhatsApp does.Any other messages will be using the normal
Person
as they did until now, so they'll be grouped together.Motivation and context
Counterpart of element-hq/element-x-ios#2397 for Android.
Screenshots / GIFs
Tests
Tested devices
Checklist