Use new functions exposed by Element Call about PiP

[bmarty]

Content

• Communicate with Element Call about PiP status.
• Also only use eventSink to communicate with the Presenter, instead of having public methods.
• Change WeakReference to an Activity to a listener and update tests.

Motivation and context

Closes #3326

Screenshots / GIFs

Tests

• Change Element Call url to https://pr2573--element-call.netlify.app/
• Start a call and play with the Pip mode
• Note that if the call is in error, the pip mode will not start, but the call will be terminated. This can be tested when entering pip mode just after starting the call (and this is maybe a thing to fix on Element Call side. The call is not in error, but not fully started yet CC @robintown )

Note: using regular (so not deployed) Element Call should not be impacted by this change.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gEe6Pw

[codecov]

Codecov Report

Attention: Patch coverage is 45.58824% with 37 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (1b7c0db) to head (7f4b846).
Report is 12 commits behind head on develop.

Files	Patch %	Lines
...droid/features/call/impl/ui/ElementCallActivity.kt	0.00%	28 Missing ⚠️
...d/features/call/impl/utils/WebViewPipController.kt	28.57%	5 Missing ⚠️
...eatures/call/impl/pip/PictureInPicturePresenter.kt	84.61%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3334      +/-   ##
===========================================
- Coverage    82.75%   82.69%   -0.07%     
===========================================
  Files         1680     1681       +1     
  Lines        39382    39415      +33     
  Branches      4777     4787      +10     
===========================================
+ Hits         32591    32594       +3     
- Misses        5117     5146      +29     
- Partials      1674     1675       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Some remarks, let me know what you think

[ganfra]

I find the naming a bit weird, especially with the default implementation being WebViewWebPipApi.
I'd have call it PipController maybe?

[bmarty]

OK, done

[ganfra]

I don't really like the fact we leak the fact it's an Activity, can we just try to find another name?

[bmarty]

PipView maybe?

[ganfra]

Instead of keeping a reference to the eventSink in a seperate value, I'd instead keep everything alive inside the content block :

setContent {
            val pipState = pictureInPicturePresenter.present()
            val pipEventSink by rememberUpdatedState(pipState.eventSink)
            DisposableEffect(Unit) {
                val onUserLeaveHintListener = Runnable {
                    pipEventSink(PictureInPictureEvents.EnterPictureInPicture)
                }
                val onPictureInPictureModeChangedListener = Consumer { value: PictureInPictureModeChangedInfo ->
                    pipEventSink(PictureInPictureEvents.OnPictureInPictureModeChanged(value.isInPictureInPictureMode))
                }
                addOnPictureInPictureModeChangedListener(onPictureInPictureModeChangedListener)
                addOnUserLeaveHintListener(onUserLeaveHintListener)
                onDispose {
                    removeOnPictureInPictureModeChangedListener(onPictureInPictureModeChangedListener)
                    removeOnUserLeaveHintListener(onUserLeaveHintListener)
                }
            }
            [...]
}

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud