Allow PictureInPicture mode for Element Call.
#3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
Z-NextRelease
bmarty
changed the title
PictureInPicturePictureInPicture mode for Element Call.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3345 +/- ##
========================================
Coverage 82.69% 82.70%
========================================
Files 1681 1681
Lines 39415 39406 -9
Branches 4787 4785 -2
========================================
- Hits 32594 32589 -5
+ Misses 5146 5143 -3
+ Partials 1675 1674 -1 ☔ View full report in Codecov by Sentry. |
ganfra
approved these changes
Aug 27, 2024
| title = "Picture in Picture for Calls", | ||
| description = "Allow the Call to be rendered in PiP mode", | ||
| defaultValue = { it.buildType != BuildType.RELEASE }, | ||
| isFinished = false, |
There was a problem hiding this comment.
Should we not use isFinished = true first?
|
Ok for me, just one question. |
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove feature flag
PictureInPicture