Fix a couple of build-time warnings in Gradle output #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3349 +/- ##
===========================================
- Coverage 82.62% 82.61% -0.02%
===========================================
Files 1699 1699
Lines 39979 39979
Branches 4864 4864
===========================================
- Hits 33033 33029 -4
- Misses 5229 5230 +1
- Partials 1717 1720 +3 ☔ View full report in Codecov by Sentry. |
|
|
Fixes the warning:
> Configure project :
dependency.analysis.autoapply is set to false, but this is now the
only behavior, and the flag has no effect. You should remove it from
your build scripts.
Signed-off-by: Joe Groocock <me@frebib.net>
> Task :plugins:compileKotlin
w: file:///.../plugins/src/main/kotlin/extension/KoverExtension.kt:70:109
'capitalized(): String' is deprecated. This was never intended as a
public API.
Signed-off-by: Joe Groocock <me@frebib.net>
bmarty
reviewed
Sep 30, 2024
| @@ -58,7 +58,7 @@ fun Project.setupKover() { | |||
| task("koverVerifyAll") { | |||
| group = "verification" | |||
| description = "Verifies the code coverage of all subprojects." | |||
| val dependencies = listOf(":app:koverVerifyGplayDebug") + koverVariants.map { ":app:koverVerify${it.capitalized()}" } | |||
| val dependencies = listOf(":app:koverVerifyGplayDebug") + koverVariants.map { ":app:koverVerify${it.replaceFirstChar(Char::titlecase)}" } | |||
| @@ -46,6 +46,3 @@ android.experimental.enableTestFixtures=true | |||
|
|
|||
| # Create BuildConfig files as bytecode to avoid Java compilation phase | |||
| android.enableBuildConfigAsBytecode=true | |||
|
|
|||
| # By default, the plugin applies itself to all subprojects, but we don't want that as it would cause issues with builds using local AARs | |||
| dependency.analysis.autoapply=false | |||
There was a problem hiding this comment.
What was the warning OOI? (doc I have found)
Also have you check that building the application using a local SDK is still wroking after this change?
There was a problem hiding this comment.
I think it's:
dependency.analysis.autoapply is set to false, but this is now the only behavior, and the flag has no effect. You should remove it from your build scripts.
bmarty
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Fix a couple of warnings. See commit messages for what and why
Motivation and context
They were easy to fix and annoying me
Screenshots / GIFs
Tests
Tested devices
Checklist