Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes around logging out. #3356

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Small fixes around logging out. #3356

merged 5 commits into from
Aug 29, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 29, 2024

Content

Ensure that the url returned during a signout is used to be presented to the user.

Motivation and context

Application consistency.

Screenshots / GIFs

Tests

I do not know how to get an url after a sign out, to be fair...

  • Signout from the pin unlock screen
  • if an url is returned, it should then be opened in a custom chrome tab.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Bugfix For bug fix label Aug 29, 2024
@bmarty bmarty requested a review from a team as a code owner August 29, 2024 10:26
@bmarty bmarty requested review from ganfra and removed request for a team August 29, 2024 10:26
Copy link
Contributor

github-actions bot commented Aug 29, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/eDGpUA

Copy link

sonarcloud bot commented Aug 29, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@bmarty bmarty enabled auto-merge August 29, 2024 10:40
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (004679c) to head (aae4487).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...d/features/lockscreen/impl/unlock/PinUnlockView.kt 30.00% 3 Missing and 4 partials ⚠️
...ckscreen/impl/unlock/activity/PinUnlockActivity.kt 0.00% 5 Missing ⚠️
...o/element/android/features/logout/api/util/Util.kt 0.00% 3 Missing ⚠️
...droid/features/logout/impl/DefaultLogoutUseCase.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3356      +/-   ##
===========================================
- Coverage    82.69%   82.66%   -0.03%     
===========================================
  Files         1681     1682       +1     
  Lines        39415    39430      +15     
  Branches      4788     4793       +5     
===========================================
+ Hits         32594    32595       +1     
- Misses        5147     5157      +10     
- Partials      1674     1678       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 1009fb3 into develop Aug 29, 2024
25 of 28 checks passed
@bmarty bmarty deleted the feature/bma/signOutFixes branch August 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants