Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner entry point to set up recovery #3360

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 29, 2024

Content

Add banner entry point to set up recovery.

Motivation and context

Now that the recovery can be reset, we want to enforce again the user to set up the recovery.

Part of #3329

Screenshots / GIFs

image

SetUpRecoveryBanner

Tests

  • Login
  • Reset recovery key
  • Observe that the new banner is displayed in the room list.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner August 29, 2024 16:37
@bmarty bmarty requested review from ganfra and removed request for a team August 29, 2024 16:37
@bmarty bmarty added PR-Change For updates to an existing feature Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Aug 29, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Aug 29, 2024
@bmarty bmarty mentioned this pull request Aug 29, 2024
8 tasks
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2tkxZ5

Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (d372697) to head (d93762b).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...es/roomlist/impl/components/RoomListContentView.kt 78.57% 2 Missing and 1 partial ⚠️
...roomlist/impl/components/SetUpRecoveryKeyBanner.kt 87.50% 0 Missing and 1 partial ⚠️
...eatures/securebackup/api/SecureBackupEntryPoint.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3360   +/-   ##
========================================
  Coverage    82.63%   82.63%           
========================================
  Files         1683     1684    +1     
  Lines        39456    39475   +19     
  Branches      4798     4798           
========================================
+ Hits         32603    32622   +19     
- Misses        5174     5175    +1     
+ Partials      1679     1678    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty enabled auto-merge August 30, 2024 14:21
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 30, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 30, 2024
@bmarty bmarty merged commit 31d0621 into develop Aug 30, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/sessionVerificationBannerIsBack branch August 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants