Fix avatar sometimes not loading

[bmarty]

Content

It seems that since the last SDK release, Client.getMediaThumbnail cannot be run in multiple thread, else the SDK report a locked database error. The last commit of this PR add a mutex.

First commit are just rework, name change, and adding log to help investigating such issues.

Motivation and context

Closes #3354

Screenshots / GIFs

Tests

Using an account with many rooms:

• kill the app
• start the app
• filter the room list on People
• observe that with this change, all the avatar are loaded.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Hpsrsj

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (f40480e) to head (cdf6900).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...raries/matrix/ui/media/AvatarDataFetcherFactory.kt	0.00%	8 Missing ⚠️
...roid/libraries/matrix/ui/media/CoilMediaFetcher.kt	0.00%	8 Missing ⚠️
.../matrix/ui/media/MediaRequestDataFetcherFactory.kt	0.00%	8 Missing ⚠️
.../libraries/matrix/ui/media/ImageLoaderFactories.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3366      +/-   ##
===========================================
- Coverage    82.62%   82.61%   -0.02%     
===========================================
  Files         1683     1685       +2     
  Lines        39456    39462       +6     
  Branches      4798     4800       +2     
===========================================
+ Hits         32602    32603       +1     
- Misses        5174     5180       +6     
+ Partials      1680     1679       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

Fix on the sdk is on his way : matrix-org/matrix-rust-sdk#3928

[ganfra]

Lets remove the fix and keep everything else as the issue is now fixed in the sdk.

[bmarty]

Done, thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud