-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide distinct cache directory to the Rust SDK. #3370
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
@Hywan can you have a look on this PR please? Since the application is playing with files created by the SDK, it would be nice if you can confirm that what is done is fine. Please let me know if you have any question. Thanks! |
It's nice to put the cache in a different directory than the store, so that it makes really clear one can be dropped or not, and avoid accident. I think it's good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this
907b2d2
to
951dff8
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3370 +/- ##
===========================================
- Coverage 82.64% 82.60% -0.05%
===========================================
Files 1684 1685 +1
Lines 39507 39535 +28
Branches 4806 4810 +4
===========================================
+ Hits 32650 32656 +6
- Misses 5175 5198 +23
+ Partials 1682 1681 -1 ☔ View full report in Codecov by Sentry. |
Content
Provide distinct cache directory to the Rust SDK.
Motivation and context
Fix a TODO and let the system be able to delete cache data if necessary (good practice)
Screenshots / GIFs
Previously the event-cache files were stored in the
sessions/id
folder.Note: this PR does not delete the existingevent-cache
files, but user will have to logout soon anyway.AppMigration06
moves the cache files now.Tests
Everything should work as expected.
Tested devices
Checklist