Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right colors for @room mention pills #3376

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Sep 2, 2024

Content

Since an @room mentions will also implicitly mention the current use, it should use the same color as an explicit mention to the current user.

Motivation and context

Fixes #3374.

Screenshots / GIFs

Before After

Tests

  • Open a room with an @room mention.
  • Check the right colors are used.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Sep 2, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner September 2, 2024 09:12
@jmartinesp jmartinesp requested review from ganfra and removed request for a team September 2, 2024 09:12
@jmartinesp jmartinesp marked this pull request as draft September 2, 2024 09:12
Copy link
Contributor

github-actions bot commented Sep 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/E7E4mF

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (31d0621) to head (d159136).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3376      +/-   ##
===========================================
+ Coverage    82.64%   82.65%   +0.01%     
===========================================
  Files         1684     1684              
  Lines        39507    39507              
  Branches      4806     4806              
===========================================
+ Hits         32650    32654       +4     
+ Misses        5175     5173       -2     
+ Partials      1682     1680       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp force-pushed the fix/jme/3374-at-room-pill-rendering-uses-wrong-colors branch from 32c6b16 to 08a6b08 Compare September 2, 2024 09:35
@jmartinesp jmartinesp marked this pull request as ready for review September 2, 2024 09:44
Copy link

sonarcloud bot commented Sep 2, 2024

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 2, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) September 2, 2024 15:07
@jmartinesp jmartinesp merged commit 94f1388 into develop Sep 2, 2024
29 checks passed
@jmartinesp jmartinesp deleted the fix/jme/3374-at-room-pill-rendering-uses-wrong-colors branch September 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@room pill rendering is different on EX-iOS and EX-Android
2 participants