Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.matrix.rustcomponents:sdk-android to v0.2.41 #3384

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 3, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.matrix.rustcomponents:sdk-android 0.2.40 -> 0.2.41 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 3, 2024 13:30
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Sep 3, 2024
@renovate renovate bot requested review from jmartinesp and removed request for a team September 3, 2024 13:30
- Use `ClientBuilderSlidingSync` to set `SlidingSyncVersionBuilder` in `RustMatrixClientFactory`.
- `Room.toggleReaction(emoji: String, eventId: EventId)` is now `Room.toggleReaction(emoji: String, uniqueEventId: String)`, since reactions can now be applied to local echoes too in the SDK.
…nto renovate/org.matrix.rustcomponents-sdk-android-0.x
@jmartinesp
Copy link
Member

jmartinesp commented Sep 3, 2024

This PR now includes the changes in https://github.com/element-hq/element-x-android/pull/3348/files, so it's co-authored by @bmarty . Thanks for your work on that branch!

Copy link
Contributor

github-actions bot commented Sep 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hbSrWD

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 69.59459% with 135 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (45c216c) to head (cd947e2).
Report is 77 commits behind head on develop.

Files with missing lines Patch % Lines
...atures/migration/impl/migrations/AppMigration06.kt 0.00% 23 Missing ⚠️
...ibraries/push/impl/push/OnRedactedEventReceived.kt 44.44% 19 Missing and 1 partial ⚠️
...android/features/licenses/impl/LicensesProvider.kt 0.00% 10 Missing ⚠️
...droid/features/logout/impl/DefaultLogoutUseCase.kt 0.00% 8 Missing ⚠️
...raries/matrix/ui/media/AvatarDataFetcherFactory.kt 0.00% 8 Missing ⚠️
...roid/libraries/matrix/ui/media/CoilMediaFetcher.kt 0.00% 8 Missing ⚠️
.../matrix/ui/media/MediaRequestDataFetcherFactory.kt 0.00% 8 Missing ⚠️
...es/push/impl/notifications/NotificationRenderer.kt 81.39% 5 Missing and 3 partials ⚠️
...d/features/lockscreen/impl/unlock/PinUnlockView.kt 30.00% 3 Missing and 4 partials ⚠️
...ckscreen/impl/unlock/activity/PinUnlockActivity.kt 0.00% 5 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3384      +/-   ##
===========================================
- Coverage    82.69%   82.60%   -0.10%     
===========================================
  Files         1681     1694      +13     
  Lines        39415    39651     +236     
  Branches      4788     4821      +33     
===========================================
+ Hits         32594    32752     +158     
- Misses        5147     5216      +69     
- Partials      1674     1683       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 3, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the title of the other PR (Allow reaction to non sent Event (local echo for reaction)) will not appear in the changelog (I think)

Copy link
Contributor Author

renovate bot commented Sep 3, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jmartinesp jmartinesp merged commit 9fb82a1 into develop Sep 3, 2024
27 of 29 checks passed
@jmartinesp jmartinesp deleted the renovate/org.matrix.rustcomponents-sdk-android-0.x branch September 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants