-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip device verification screen when creating a new account using OIDC #3395
Conversation
@@ -66,18 +75,32 @@ class VerifySelfSessionPresenter @Inject constructor( | |||
val recoveryState by encryptionService.recoveryStateStateFlow.collectAsState() | |||
val stateAndDispatch = stateMachine.rememberStateAndDispatch() | |||
val skipVerification by sessionPreferencesStore.isSessionVerificationSkipped().collectAsState(initial = false) | |||
val needsVerification by sessionVerificationService.needsSessionVerification.collectAsState(initial = true) | |||
val sessionVerifiedStatus by sessionVerificationService.sessionVerifiedStatus.collectAsState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use needsSessionVerification
to avoid the initial true
value.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3395 +/- ##
===========================================
- Coverage 82.60% 82.58% -0.02%
===========================================
Files 1694 1695 +1
Lines 39651 39671 +20
Branches 4821 4827 +6
===========================================
+ Hits 32752 32762 +10
- Misses 5216 5220 +4
- Partials 1683 1689 +6 ☔ View full report in Codecov by Sentry. |
Content
It can happen that the session is automatically verified and in this case the FTUE verification step has to be skipped.
This PR handle this.
Note that some shortcut had been taken to show the confirmation screen when the user enter a recovery key, so I had to add a parameter
showDeviceVerifiedScreen
to handle this case properly.Motivation and context
Closes #3279
Screenshots / GIFs
Tests
Note that I have seen the "Confirm your identity" for a few millis, it seems that the SDK emit a
SessionVerifiedStatus.NotVerified
between theSessionVerifiedStatus.Unknown
andSessionVerifiedStatus.Verified
, but I need to check again befor reporting to the SDK.Tested devices
Checklist