-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency androidx.compose:compose-bom to v2024.09.00 #3399
Conversation
Notes: rich composer is broken, toggling to rich -> back crashes the app.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
I have done some smoke tests and it's working fine on API34. Will test on API33 with a virtual keyboard.
Hard to spot all the regressions in all those hidden by default screenshot diff, but I have reported some. Maybe not blocking.
@@ -144,6 +144,7 @@ fun TimelineView( | |||
key = { timelineItem -> timelineItem.identifier() }, | |||
) { timelineItem -> | |||
TimelineItemRow( | |||
modifier = Modifier.animateItem(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, maybe I'll have to either change the animation, try to move it down the composable hierarchy or partially/completely remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rendering is a bit weird with the final dot, but the new rendering for progress bars with known progress values is like this, which the space between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this is also the new way these components are styled: https://m3.material.io/components/sliders/overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
override fun focusSearch(direction: Int): View? { | ||
return null | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
FWIW, this is also the current behaviour in |
Actually, I surrender... I've tried to make it work for several hours and failed to do so (at least not breaking other stuff). I think this happens because we resize the bottom sheet to match the offset, while we should be resizing its contents. I'd rather try to solve that in a separate PR than get this one stuck by that. |
Quality Gate passedIssues Measures |
Force merged this as Maestro was passing after retrying, although it was marked as failed for some reason 🤷 . |
This PR contains the following updates:
2024.08.00
->2024.09.00
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.