Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency androidx.compose:compose-bom to v2024.09.00 #3399

Merged
merged 16 commits into from
Sep 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 5, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.compose:compose-bom 2024.08.00 -> 2024.09.00 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 5, 2024 00:09
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Sep 5, 2024
@renovate renovate bot requested review from jmartinesp and removed request for a team September 5, 2024 00:09
Notes: rich composer is broken, toggling to rich -> back crashes the app.
Copy link
Contributor Author

renovate bot commented Sep 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VpPNbX

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 12, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 79.64286% with 57 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (cec945c) to head (c59e6f1).
Report is 102 commits behind head on develop.

Files with missing lines Patch % Lines
...es/mediaviewer/api/local/pdf/PdfRendererManager.kt 0.00% 13 Missing ⚠️
...d/libraries/mediaviewer/api/local/pdf/PdfViewer.kt 65.38% 7 Missing and 2 partials ⚠️
...aries/designsystem/components/ClickableLinkText.kt 0.00% 6 Missing and 1 partial ⚠️
...droid/libraries/androidutils/system/SystemUtils.kt 0.00% 6 Missing ⚠️
...droid/libraries/mediapickers/api/PickerLauncher.kt 0.00% 4 Missing ⚠️
...droid/features/call/impl/ui/ElementCallActivity.kt 0.00% 3 Missing ⚠️
...ndroid/libraries/designsystem/modifiers/ApplyIf.kt 25.00% 2 Missing and 1 partial ⚠️
...s/impl/timeline/components/TimelineItemEventRow.kt 90.00% 0 Missing and 2 partials ⚠️
...ndroid/features/roomlist/impl/RoomListPresenter.kt 33.33% 0 Missing and 2 partials ⚠️
...es/network/interceptors/FormattedJsonHttpLogger.kt 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3399      +/-   ##
===========================================
- Coverage    82.67%   82.66%   -0.01%     
===========================================
  Files         1731     1732       +1     
  Lines        40843    40958     +115     
  Branches      4968     4955      -13     
===========================================
+ Hits         33767    33858      +91     
- Misses        5315     5342      +27     
+ Partials      1761     1758       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member

There seem to be some changes to shadows:

image image

It seems like the elevation now gives you less prominent shadows.

Also progress bars now display the 'background track color' or something like that:

image

Some textfields also changed their background color:

image

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 13, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 13, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

I have done some smoke tests and it's working fine on API34. Will test on API33 with a virtual keyboard.

Hard to spot all the regressions in all those hidden by default screenshot diff, but I have reported some. Maybe not blocking.

@@ -144,6 +144,7 @@ fun TimelineView(
key = { timelineItem -> timelineItem.identifier() },
) { timelineItem ->
TimelineItemRow(
modifier = Modifier.animateItem(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the cause of a weird animation when expanding/collapsing items:

ItemAnimation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, maybe I'll have to either change the animation, try to move it down the composable hierarchy or partially/completely remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is strange here, and so the rendering in poll event is weird

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering is a bit weird with the final dot, but the new rendering for progress bars with known progress values is like this, which the space between them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other noticeable diff:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this is also the new way these components are styled: https://m3.material.io/components/sliders/overview

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this issue fixed!

image


override fun focusSearch(direction: Int): View? {
return null
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bmarty
Copy link
Member

bmarty commented Sep 18, 2024

Also, when text formatting is enabled, it's not possible to extend the bottom sheet using the handle and the top area of the bottom sheet. Looks like a regression. Swiping the input text area works.

image

@jmartinesp
Copy link
Member

Also, when text formatting is enabled, it's not possible to extend the bottom sheet using the handle and the top area of the bottom sheet. Looks like a regression. Swiping the input text area works.

FWIW, this is also the current behaviour in develop. I can try to fix it though, if I can find the source.

@jmartinesp
Copy link
Member

FWIW, this is also the current behaviour in develop. I can try to fix it though, if I can find the source.

Actually, I surrender... I've tried to make it work for several hours and failed to do so (at least not breaking other stuff). I think this happens because we resize the bottom sheet to match the offset, while we should be resizing its contents. I'd rather try to solve that in a separate PR than get this one stuck by that.

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 19, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 19, 2024
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 25, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 26, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 26, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) September 26, 2024 06:55
@jmartinesp jmartinesp merged commit 9756afc into develop Sep 26, 2024
27 of 30 checks passed
@jmartinesp jmartinesp deleted the renovate/compose.bom branch September 26, 2024 07:30
@jmartinesp
Copy link
Member

Force merged this as Maestro was passing after retrying, although it was marked as failed for some reason 🤷 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants