Recovery key formatting and wording iteration

[bmarty]

Content

If a passphrase is entered by the user the RecoveryKeyVisualTransformation does not apply. This PR is adding 2 screenshots to demo this.

Also stop using the wording screen_recovery_key_confirm_key_label (Recovery key or passcode), it was wrong. Just use Recovery key (similar to iOS and compliant with design)

Motivation and context

Improve wording and screenshot test.

Screenshots / GIFs

Tests

• Observe the new wording and recovery key formatting when its a passphrase in the recorded screenshots.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[bmarty]

Not sure why this is recorded again, the timestamp is not rendered the same way :/.
There is no change in this PR about this.

[jmartinesp]

This was recorded from a fork, maybe their CI setup is somehow in a different TZ?

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5uHPCS

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jmartinesp]

Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (9f2db3e) to head (bab85c7).
Report is 19 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3409   +/-   ##
========================================
  Coverage    82.62%   82.62%           
========================================
  Files         1694     1694           
  Lines        39685    39686    +1     
  Branches      4831     4830    -1     
========================================
+ Hits         32788    32789    +1     
  Misses        5205     5205           
  Partials      1692     1692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.