Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline : remove the encrypted history banner #3410

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 6, 2024

Content

Remove the encrypted history banner for now as it needs more design and consideration.
This should come back with a proper implementation from the rust sdk.

Motivation and context

Closes #3391

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added PR-Change For updates to an existing feature Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Sep 6, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e9Tuus

@ganfra ganfra marked this pull request as ready for review September 6, 2024 09:59
@ganfra ganfra requested a review from a team as a code owner September 6, 2024 09:59
@ganfra ganfra requested review from bmarty and removed request for a team September 6, 2024 09:59
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (d611c1f) to head (b9a5819).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3410   +/-   ##
========================================
  Coverage    82.62%   82.62%           
========================================
  Files         1699     1697    -2     
  Lines        39963    39940   -23     
  Branches      4862     4860    -2     
========================================
- Hits         33019    33000   -19     
+ Misses        5229     5226    -3     
+ Partials      1715     1714    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@ganfra ganfra merged commit 7549d5f into develop Sep 9, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/timeline_utd branch September 9, 2024 14:24
@bmarty bmarty mentioned this pull request Sep 11, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline : remove the history not available banner
3 participants