-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete old log files #3413
Delete old log files #3413
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Although I'm not sure it completely fixes the issue. @richvdh seemed to have also way more 'valid' log files than expected (> 168).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3413 +/- ##
===========================================
+ Coverage 82.61% 82.68% +0.06%
===========================================
Files 1694 1696 +2
Lines 39685 39695 +10
Branches 4831 4831
===========================================
+ Hits 32787 32821 +34
+ Misses 5205 5177 -28
- Partials 1693 1697 +4 ☔ View full report in Codecov by Sentry. |
Content
Add an application migration to delete the logs which use previous filename format.
Also add missing test and fix a bug where migrating application was performed on fresh install. This had no effect but was not clean.
Motivation and context
Closes #3406
Screenshots / GIFs
Tests
Tested devices
Checklist