Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old log files #3413

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Delete old log files #3413

merged 7 commits into from
Sep 6, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 6, 2024

Content

Add an application migration to delete the logs which use previous filename format.

Also add missing test and fix a bug where migrating application was performed on fresh install. This had no effect but was not clean.

Motivation and context

Closes #3406

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 6, 2024 09:54
@bmarty bmarty requested review from jmartinesp and removed request for a team September 6, 2024 09:54
@bmarty bmarty added the PR-Misc For other changes label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mQnuoK

Copy link

sonarcloud bot commented Sep 6, 2024

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Although I'm not sure it completely fixes the issue. @richvdh seemed to have also way more 'valid' log files than expected (> 168).

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (4b4acfc) to head (148c49c).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...ures/rageshake/impl/reporter/DefaultBugReporter.kt 0.00% 3 Missing ⚠️
...ures/rageshake/impl/logs/DefaultLogFilesRemover.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3413      +/-   ##
===========================================
+ Coverage    82.61%   82.68%   +0.06%     
===========================================
  Files         1694     1696       +2     
  Lines        39685    39695      +10     
  Branches      4831     4831              
===========================================
+ Hits         32787    32821      +34     
+ Misses        5205     5177      -28     
- Partials      1693     1697       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@bmarty bmarty changed the title Feature/bma/delete old log files Delete old log files Sep 6, 2024
@bmarty bmarty merged commit d12c6f3 into develop Sep 6, 2024
26 of 28 checks passed
@bmarty bmarty deleted the feature/bma/deleteOldLogFiles branch September 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

old logfiles are not being cleaned up
2 participants