Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned messages banner : adjust indicator to match design. #3415

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Pinned messages banner : adjust indicator to match design. #3415

merged 3 commits into from
Sep 6, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 6, 2024

No description provided.

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 6, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZhC7Be

@ganfra ganfra added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Sep 6, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (4b4acfc) to head (6597fe2).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/impl/pinned/banner/PinnedMessagesBannerView.kt 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3415   +/-   ##
========================================
  Coverage    82.61%   82.62%           
========================================
  Files         1694     1694           
  Lines        39685    39687    +2     
  Branches      4831     4836    +5     
========================================
+ Hits         32787    32790    +3     
  Misses        5205     5205           
+ Partials      1693     1692    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra marked this pull request as ready for review September 6, 2024 14:29
@ganfra ganfra requested a review from a team as a code owner September 6, 2024 14:29
@ganfra ganfra requested review from bmarty and removed request for a team September 6, 2024 14:29
bmarty
bmarty reviewed Sep 6, 2024
View reviewed changes
...n/kotlin/io/element/android/features/messages/impl/pinned/banner/PinnedMessagesBannerView.kt Outdated
strokeWidth
)
}
.shadow(elevation = 5.dp, spotColor = Color.Transparent)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format the file please?

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ganfra ganfra merged commit 87dbed9 into develop Sep 6, 2024
27 checks passed
@ganfra ganfra deleted the feature/fga/pinned_messages_banner_indicators branch September 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Wip For anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganfra @bmarty