Fix new logins with Simplified SS using the proxy #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3417 +/- ##
========================================
Coverage 82.61% 82.61%
========================================
Files 1694 1694
Lines 39685 39685
Branches 4831 4831
========================================
Hits 32787 32787
Misses 5205 5205
Partials 1693 1693 ☔ View full report in Codecov by Sentry. |
ganfra
reviewed
Sep 6, 2024
| val slidingSync = when { | ||
| AuthenticationConfig.SLIDING_SYNC_PROXY_URL != null -> ClientBuilderSlidingSync.CustomProxy(AuthenticationConfig.SLIDING_SYNC_PROXY_URL!!) | ||
| appPreferencesStore.isSimplifiedSlidingSyncEnabledFlow().first() -> ClientBuilderSlidingSync.Simplified | ||
| restore -> ClientBuilderSlidingSync.Restored |
There was a problem hiding this comment.
Should we not checked first if restore is true?
ganfra
approved these changes
Sep 6, 2024
|
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
jmartinesp
deleted the
fix/jme/session-restoration-using-proxy-instead-of-sss
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Setup whether to use the proxy or native sliding sync at an earlier stage when signing in, so the
SlidingSyncVersionis properly populated, stored and later restored.Motivation and context
With the current code, Simplified Sliding Sync was never used even if it was enabled in developer options.
Tests
/syncrequests hit the right endpoint (_matrix/client/unstable/org.matrix.simplified_msc3575/syncinstead of_matrix/client/unstable/org.matrix.msc3575/sync)./syncrequests.Tested devices
Checklist