Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to AGPL #3422

Merged
merged 16 commits into from
Sep 6, 2024
Merged

Change license to AGPL #3422

merged 16 commits into from
Sep 6, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 6, 2024

Content

Change license to AGPL.
Please read https://element.io/blog/sustainable-licensing-at-element-with-agpl/ for more details.

Motivation and context

Screenshots / GIFs

Tests

  • Should not impact production code nor script

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 6, 2024 16:13
@bmarty bmarty requested review from jmartinesp and manuroe and removed request for a team September 6, 2024 16:13
@bmarty bmarty added the PR-Misc For other changes label Sep 6, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm going to trust both you and the CI on this one 🫡

Copy link
Contributor

github-actions bot commented Sep 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/8ckodX

@jmartinesp
Copy link
Member

That said, it seems like both sample_avatar.xml and search_forbidden_strings.pl still have an Apache license header. I don't know if it's because we imported those from somewhere else?

Copy link

sonarcloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (b802a19) to head (5e061fa).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3422   +/-   ##
========================================
  Coverage    82.65%   82.65%           
========================================
  Files         1705     1705           
  Lines        40072    40072           
  Branches      4875     4875           
========================================
  Hits         33123    33123           
  Misses        5231     5231           
  Partials      1718     1718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty
Copy link
Member Author

bmarty commented Sep 6, 2024

That said, it seems like both sample_avatar.xml and search_forbidden_strings.pl still have an Apache license header. I don't know if it's because we imported those from somewhere else?

First one is imported from Google codebase, and second one is hosted in another repo (you have a copy in your tmp folder probably)

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 6, 2024
@bmarty bmarty merged commit 6251cb9 into develop Sep 6, 2024
33 checks passed
@bmarty bmarty deleted the feature/bma/agpl branch September 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants