Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] : fix self verification flow #3426

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 9, 2024

Content

This PR solves 2 things :

  • There were race condition in the creation of the verificationController so nothing would work in those cases.
  • Cancellation of verification wasn't correctly done in some cases

Motivation and context

Closes #3418

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mDq21z

@ganfra ganfra marked this pull request as ready for review September 9, 2024 09:11
@ganfra ganfra requested a review from a team as a code owner September 9, 2024 09:11
@ganfra ganfra requested review from jmartinesp and removed request for a team September 9, 2024 09:11
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (fc0bb64) to head (a7ab8ee).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3426   +/-   ##
========================================
  Coverage    82.65%   82.65%           
========================================
  Files         1705     1705           
  Lines        40076    40076           
  Branches      4881     4881           
========================================
  Hits         33125    33125           
  Misses        5233     5233           
  Partials      1718     1718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM and I confirm it fixes the issue, thanks!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@ganfra ganfra changed the title Feature/fga/fix self verification flow [Bugfix] : fix self verification flow Sep 9, 2024
@ganfra ganfra merged commit a284177 into develop Sep 9, 2024
34 checks passed
@ganfra ganfra deleted the feature/fga/fix_self_verification_flow branch September 9, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device verification barely works on SSS
2 participants