Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wait list screen #3428

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Remove Wait list screen #3428

merged 1 commit into from
Sep 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 9, 2024

Content

Remove a screen that was never used and should never be used in the future.

Motivation and context

Closes #3293

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 9, 2024 12:08
@bmarty bmarty requested review from ganfra and removed request for a team September 9, 2024 12:08
Copy link
Contributor

github-actions bot commented Sep 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/cZY16e

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (a284177) to head (76bc70a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...in/impl/screens/loginpassword/LoginPasswordView.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3428      +/-   ##
===========================================
- Coverage    82.65%   82.62%   -0.04%     
===========================================
  Files         1705     1699       -6     
  Lines        40076    39963     -113     
  Branches      4881     4862      -19     
===========================================
- Hits         33125    33019     -106     
+ Misses        5233     5229       -4     
+ Partials      1718     1715       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 9, 2024
@bmarty
Copy link
Member Author

bmarty commented Sep 9, 2024

Maestro is failing for an unrelated reason (and this is getting investigating)

@bmarty bmarty disabled auto-merge September 9, 2024 13:30
@bmarty bmarty merged commit d611c1f into develop Sep 9, 2024
27 of 31 checks passed
@bmarty bmarty deleted the feature/bma/removeWaitListScreen branch September 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Remove the SS proxy waiting list
2 participants